adjust TargetActivatedOrTriggeredAbility
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
TargetActivatedOrTriggeredAbility takes a FilterStackObject rather than a FilterActivatedOrTriggeredAbility, which is bad style. Looking at the code I suspect Adric, Lithoform Engine, Vantress Visions are bugged as a result (though before the #12220 rework, the bug was masked). The rest might be okay because they're checking characteristics of a source, not sure.
Also, FilterActivatedOrTriggeredAbility is missing its copy() override and thus not using its copy constructor.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating TargetActivatedOrTriggeredAbility and FilterActivatedOrTriggeredAbility, then review the #12220 rework and the handling of Adric, Lithoform Engine, and Vantress Visions. Check the related source-characteristic cases as well. Done means the ability uses the intended filter type, its copying behavior is covered, and the suspected affected cards behave correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100