magefree / magefree/mage

Squad doesn't sum cost

Open
#12,563 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

When casting a spell with the Squad keyword (e.g. [[Sicarian Infiltrator]]), the user is prompted to input the number of times they want to pay the squad cost. Then, instead of summing the cost and displaying the total of how much the user must pay, the cost displayed is the base cost of the spell. Then when that's paid, the cost of one squad, and then when that's paid it displays the next, and so on. For example, Sicarian Infiltrator is {2}{U}, so that's the initially displayed cost, then the displayed cost is {2}, then when it's paid the cost is {2} again, then {2} again, for as many times as you selected to pay for squad.

So initial cost:
![image](https://github.com/magefree/mage/assets/26198472/55b34147-f7f2-4366-9bdb-37fe10e8cdf0)
Then for every squad cost:
![image](https://github.com/magefree/mage/assets/26198472/9d8695f9-9264-42ad-b044-b56f187decf3)

This makes it unnecessarily difficult to keep track of how much mana is left to be paid. An extremely similar mechanic, multikicker, does not share this problem, as it sums the cost of each "kick" into a single cost. See below in the case of [[Everflowing Chalice]], kicking it 3 times:

![image](https://github.com/magefree/mage/assets/26198472/cf72d84f-decd-4da9-9a50-43a654d3344e)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing how the Squad keyword builds and presents its payment cost, then compare that flow with multikicker using Sicarian Infiltrator and Everflowing Chalice. Verify the behavior by casting Sicarian Infiltrator with multiple Squad payments and confirm that the full combined cost is displayed and paid as one cost.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.