magefree / magefree/mage

Refactor: make common effect for "[player] exiles [...] they control"

Open
#12,541 1 comment 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

https://scryfall.com/search?q=o%3A%2Fexiles+.*+they+control%2F+-%22living+death%22+-%22living+end%22+-%22scrap+mastery%22&unique=cards&as=grid&order=name

Nicol Bolas, Dragon-God & Descent Into Madness are a different effect with the choice to exile a card from hand, but all 5 others are similar enough to deserve a common effect.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the linked Scryfall search and identify the five matching cards, excluding Nicol Bolas, Dragon-God and Descent Into Madness. Compare their implementations to find the repeated exile effect, then consolidate it into a common effect and verify that the five cards retain their intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.