Permanent’s LKI and other time related data must be persisted (read only)
Open
refactoring
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
See details in https://github.com/magefree/mage/pull/12482#discussion_r1647082016
All time related data like LKI must be persisted to static data in the moment of the save. Current code uses many dynamic methods with game param, and saved permanent return “current” object state instead really saved state. It was broken few years ago.
Possible solution: introduce Permanent:copyToSave method and return permanent object with locked (read only) characteristics.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.