magefree / magefree/mage

lookAtCards/reveal and fireUpdatePlayersEvent must be reworked

Open
#12,480 0 comments 1 reaction 1 assignee Claimed by @JayDi85 View on GitHub
bug refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

`lookAtCards` used in some continuous effects (example `LookAtTopCardOfLibraryAnyTimeEffect`), but it call full game update for all players. It's potentially full of bugs due wrong game life cycle usage -- game must not send unfinished game state (see problems example in #11487).

Another problem: it's one time action -- all lookAt info will be lost on next game update or reconnect.

So all `lookAtCards` logic must be reworked:
* [ ] keep "looked at" data in game state for all time (until card moved to other zone, e.g. on zcc change or library shuffle);
* [ ] show "looked at" cards in all zones or choices (example: choose card from opponent's hand must show look at card);
* [ ] show "looked at" cards in own windows too (current implementation);
* [ ] support face down and looked at (see #12479);
* [ ] card reveal must use same logic (keep reveal data between updates);

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.