magefree / magefree/mage

Effects which copy multiple stack objects at once don't allow the controller to choose the order

Open
#12,418 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Some examples from this [scryfall search](https://scryfall.com/search?q=o%3A%22copy%22+-o%3A%22copy+target%22+-o%3A%22copy+each+exiled+card%22+-o%3A%22cast+any+number+of+the+copies%22+-o%3A%22copy+that%22+-o%3A%22cast+the+copy%22+-o%3A%22copy+the+spell%22+-o%3A%22copies+that%22+-o%3A%22copy+a+spell%22+-o%3A%22copy+those+cards%22+-o%3A%22copy+an+instant%22+-o%3A%22copy+%7E%22+-o%3A%22copies+it%22+-o%3A%22copy+the+next%22+-o%3A%22the+copy+isn%27t%22+-o%3A%22copy+the+exiled+card%22+-o%3A%22copy+of%22+game%3Apaper+-o%3A%22copy+this%22+-o%3A%22copy+each+card%22+-o%3A%22copy+a+card%22+-o%3A%22cast+or+copy%22+-o%3A%22copy+it%22&unique=cards&as=grid&order=name):

[[Display of Power]]:

> If you copy multiple spells with Display of Power, you can put the copies on the stack in any order.

[[Finale of Promise]]:

> Then, if X is 10 or more, you copy each of those twice and put the copies on the stack in any order.

[[Ulalek, Fused Atrocity]]

Player currently have a `chooseTriggeredAbility` choice, but this obviously only works for triggered abilities. It would be nice to have a `chooseStackObject` choice and UI for this situation - maybe it should look similar to the `chooseTriggeredAbility` UI since semantically you're doing the same thing.

These cards are also all currently using `StackObject::createCopyOnStack(...)`... maybe it would be good to have a helper method `StackObjects::createCopiesOnStack` for multiple stack objects that invokes this new player choice.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.