magefree / magefree/mage

Refactor: regroup "if no mana was spent to cast [target pointer]" in a shared condition

Open
#12,356 0 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

https://scryfall.com/search?q=o%3A%2Fif+no+mana+was+spent%2F&unique=cards&as=grid&order=name

Those cards use various means to look for the "if no mana was spent to cast [target pointer spell]" condition. I think we could make them share some code.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Scryfall search linked in the issue and inspect the card implementations that check whether no mana was spent to cast a target spell. Identify the differing condition logic and determine whether it can be represented by shared code without changing the affected cards' behavior. Done means the relevant cards use the shared condition consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.