magefree / magefree/mage

Default watchers must be renamed to use “default” naming

Open
#12,345 1 comment 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

There are many default watchers (added to game by default on init; commander and tiny leaders also have default watchers).

In most use cases it’s a hidden watchers (used inside ability/effect/hint) and dev don’t know is it required or not without ability code view.

It can be useful to rename all that watchers to “xxxDefaultWatcher”.
![IMG_0443](https://github.com/magefree/mage/assets/8344157/b427e919-119f-4a6a-b4ea-b6c81ad53f9a)

Contributor guide

No contributing guide indexed for this repository

Research direction

No files or tests are named. Start by searching the Java source for default watcher declarations and their references, then identify every watcher that should use the “xxxDefaultWatcher” naming. Done means the relevant default watchers and their references are renamed consistently without breaking the project.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.