magefree / magefree/mage

Rework Card::counters to prevent direct edit access

Open
#12,332 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Followup of #12314 (similar work, for the Player's counters)

Direct access to the Counters to add/remove counters is ill advised, as it avoid any kind of prevention/event firing.

Of note, the current implementation of [[Tawnos's Coffin]] purposely doesn't fire COUNTER_ADDED event, and it is not clear to me that's correct at this time.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with Card::counters and compare the related work in #12314, then inspect the current handling of direct counter additions and removals. The issue is complete when those operations no longer bypass prevention or events, with the Tawnos's Coffin COUNTER_ADDED behavior explicitly resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.