magefree / magefree/mage

Refactor: make a common TriggeredAbility for "Whenever [X] or more creatures attack,"

Open
#12,291 0 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Those have all their own trigger implementation:

https://scryfall.com/search?q=o%3A%2Fwhenever%5B%5E%2C%5D*or+more+creatures+attack%2C%2F&unique=cards&as=grid&order=name

We could make a common TriggeredAbility for those, maybe group them with https://scryfall.com/search?q=o%3A%2Fwhenever%5B%5E%2C%5D*or+more%5B%5E%2C%5D*attack%2C%2F&unique=cards&as=grid&order=name ?

Note: preserve the double Outcome on Duelist's Heritage depending on whose turn it is.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the separate implementations matching the linked Scryfall searches and compare their trigger behavior. Inspect Duelist's Heritage in particular before consolidating them, then verify that the shared TriggeredAbility preserves its double Outcome depending on whose turn it is.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.