magefree / magefree/mage

cleanup Targets any amount with minimum criteria for the sum (Crew, Saddle, Collect Evidence)

Open
#12,269 2 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Following the [[Nethergoyf]] implementation of its Escape target in #12267 the following classes could be aligned in their way to define a target "any number of [...] with a minimum total of Y [...]":

- `CrewAbility`
- `SaddleAbility`
- `CollectEvidenceAbility`
- `FabricationFoundry` (that one is more complex, as it is an 'exactly X' total mana cost)

Aside from Crew + Saddle, I'm not sure it is worth trying to have some common class, as they all target different zones and/or want different condition.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by comparing the implementations of CrewAbility, SaddleAbility, CollectEvidenceAbility, and FabricationFoundry with Nethergoyf's Escape target from #12267. Align the applicable targets around any-number selection with minimum totals, while deciding separately whether Crew and Saddle warrant shared code and whether FabricationFoundry belongs in the cleanup.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.