Verify test is blind to dynamically added Effect/Abilities
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
I would like it if we could find a way to refactor effects so that the verify test deep (introduced for copy check, but it is doing a little more than that) looping through Card class can find oddities.
An option would be to have one instance of the added effect/ability as member of the class, and reuse/copy it on use. The instantitated one could be static in a lot of situations. Of course this would not help with every use case.
To give an example with `DelayedTriggeredAbility`:
https://github.com/magefree/mage/blob/8771d9b7f5dee033eb54e894d89901bbaaa12a62/Mage.Sets/src/mage/cards/j/JaceCunningCastaway.java#L75-L79
The `JaceCunningCastawayDamageTriggeredAbility` class is not covered by the Verify test suite.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.