Research/fix usage of `affectedObjectsSet` before `init`
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
This is a followup to #12080
> So only 4 usages before `super.init`:
> Potential place to next refactor:
- [ ] Confirm functionality of these effects with unit test coverage
- [ ] Cleanup/refactor logic so that the subclass only runs additional code after the super
_Originally posted by @Susucre in https://github.com/magefree/mage/issues/12080#issuecomment-2053660477_
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reviewing the four `affectedObjectsSet` usages before `super.init` identified in issue #12080 and the effects they belong to. Add unit test coverage to confirm their behavior, then verify that subclass logic runs only after the superclass initialization and that the affected usages have been cleaned up.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100