Refactor: Separate the 'one or more' usage in DiesCreatureTriggeredAbility
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
A new trigger has been added for [[Vengeful Townsfolk]], using the ZONE_CHANGE_BATCH event.
https://github.com/magefree/mage/commit/559be38b00c6bc12a4b5c44f604930a20a62d86f#diff-abf8ebb472f7ec9e5064a65a0505b0f637604d5c40a482f3cc6fc7efe03e1306
[A few cards (11)](https://scryfall.com/search?q=o%3A%2Fwhenever+one+or+more.*die.*only+once%2F&unique=cards&as=grid&order=name) are using the 1 card event, as they have the "trigger only once each turn" restriction.
It would make sense to move them to the new trigger.
[A few other cards (3 currently implemented)](https://scryfall.com/search?q=o%3A%2Fwhenever+one+or+more.*die.*%2F+-o%3A%22only+once%22&unique=cards&as=grid&order=name) may have their own handling, and could probably benefit from the shared class.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with DiesCreatureTriggeredAbility and the ZONE_CHANGE_BATCH trigger added for Vengeful Townsfolk in commit 559be38b00c6bc12a4b5c44f604930a20a62d86f. Review the 11 cards with “trigger only once each turn” and the three other implemented cards to determine which should use the shared trigger. Done means the relevant card abilities share the appropriate handling without changing their trigger behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100