Refactor: Separate the player and the permanent in TapForManaAllTriggeredAbility & TapForManaAllTriggeredManaAbility
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
There is only a few cards involved with those effects, for instance [[Vorinclex, Voice of Hunger]]:
https://scryfall.com/search?q=o%3A%2Fwhenever+.*+tap+.*+for+mana%2F
The FilterPermanent is packing the player (and needs a ControllerPredicates)

I didn't investigate further, but there is no reason for the TAPPED_FOR_MANA event to not have the relevant playerId of the player tapping a permanent for mana.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating TapForManaAllTriggeredAbility, TapForManaAllTriggeredManaAbility, FilterPermanent, and the TAPPED_FOR_MANA event. Trace how the player is currently packed into the permanent filter and determine how the event should expose the playerId; done means the player and permanent are handled separately for the affected cards, including Vorinclex, Voice of Hunger.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100