magefree / magefree/mage

ManaPaidSourceWatcher tracks how many treasures were spent, not the mana generated by treasures

Open
#11,932 2 comments 0 reactions 0 assignees View on GitHub
bug refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

All currently existing "do thing based off being paid for by treasures" that I can find care about the amount of mana generated by treasures (or that any mana from treasures was spent on it), rather than the number of actual treasures used. The watcher needs to be redone such that the event includes the amount of mana if not currently available, and then it increments the `treasure` counter by the amount of mana generated by treasures.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating ManaPaidSourceWatcher and the event it consumes. Trace how treasure payments are reported and how the watcher updates its counter; done means the event exposes the generated mana when needed and the counter reflects mana generated by treasures rather than the number of treasures used.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.