magefree / magefree/mage

Unbroken case in ContinuousEffects.java with oneshot effect type

Open
#11,862 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

The case for CONTINUOUS does not break or indeed do anything, so it treats it like a one shot. I don't know if this is intentional, but it certainly doesn't look like it; and I have no idea how this code should work. I'm surprised it hasn't broken anything.

if it is correct a comment should probably be added because it certainly doesnt look like it.

![image](https://github.com/magefree/mage/assets/115711046/6acf4b8d-4b29-4285-bf13-38d30b9fd0d1)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.