magefree / magefree/mage

Players abort and pass/skip settings must be reset on any rollback (game error, disconnect, manual rollback)

Open
#11,654 1 comment 1 reaction 1 assignee Claimed by @JayDi85 View on GitHub
bug enhancement
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Reason: rollback can be broken sometime (user requested rollback but can't do anything cause he press skip button before);

Pass code in `PlayerImpl` must be refactored:
* move to passed settings object;
* reset that object on rollback request;
![shot_240115_023618](https://github.com/magefree/mage/assets/8344157/6d586056-c6f1-4016-a28c-cad59f98e868)

P.S. Additional tasks: miss reset code on game exception and disconnects, see details here: https://github.com/magefree/mage/issues/4309#issuecomment-678087387

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.