magefree / magefree/mage

Boosters are sorted by rarity even when generated by collation

Open
#11,605 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Example: Modern Masters (MMA) has a dedicated foil slot that is found after the rare at the end of the booster. The collator appears to add it last. However, it seems that it appears after the other cards of its rarity in the booster instead.

I'm not sure what part of the code is sorting the booster by rarity, but such functionality is NOT desired for boosters generated by collation with dedicated slots: they should be presented as generated.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing booster generation and collation order for Modern Masters, then locate where generated cards are sorted by rarity. Reproduce the dedicated foil-slot case and verify that boosters produced by collation preserve their generated order rather than being reordered by rarity.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.