magefree / magefree/mage

GUI: add confirm dialogs to close tourney and other buttons with critical actions

Open
#11,524 0 comments 0 reactions 0 assignees View on GitHub
bug GUI
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

* [ ] Critical actions must have a confirm dialog (see example with disconnect, concede);
* [ ] Confirm dialog for critical action must have default button on cancel, not ok (so random enter/space keys must not able to confirm it);
* [ ] Critical action buttons must be unfocusable (not so good solution) or there are must be another buttons to take a focus by default (good solution;

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the GUI handlers for closing a tournament and the existing disconnect and concede confirmation dialogs. Audit other critical-action buttons for confirmation, safe default-button behavior, and keyboard focus handling; done means every critical action follows these safeguards.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.