magefree / magefree/mage

Some card movement logs may deserve to be batched.

Open
#10,839 0 comments 0 reactions 0 assignees View on GitHub
Developers Discussion
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Some cards movement to library do log a line per card, altought there is no relevant info.
#10838 is the latest case of that.
![image](https://github.com/magefree/mage/assets/34709007/5518a8e3-0499-4bd8-a78b-a76cc7fbb032)

I am not sure of what the right way to do that is.
Have tried something in the past, but some info was cut due to batching and that did change too much the GameImpl methods, just for log purposes: #10704

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the GameImpl methods involved in card movement logging and compare the cases referenced by #10838 and the earlier attempt in #10704. Determine which per-card messages lack relevant information, while preserving details that batching would otherwise cut; done means a focused logging change with the intended details retained.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev, observability
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.