magefree / magefree/mage

Refactor: use RedirectionEffect where appropriate

Open
#10,650 1 comment 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

A bunch of cards implement damage redirection with a custom effect extending PreventionEffectImpl or ReplacementEffectImpl. We have the class `RedirectionEffect` ~~although strangely it~~ *which correctly* does not extend PreventionEffect. There are likely to be various subtle bugs in these custom classes, so ideally the common classes can be cleaned up, unit tests confirmed, and cards updated to use the common classes.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading RedirectionEffect alongside the custom effects extending PreventionEffectImpl or ReplacementEffectImpl. Locate the affected cards and existing unit tests, then compare their behavior with the common effect. Done means the relevant cards use RedirectionEffect where appropriate and the unit tests confirm the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev, testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.