magefree / magefree/mage

Dialog boxes improvements

Open
#10,198 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

* Need a button to be able to close all dialog boxes at once (exile/revealed/graveyard etc)
* Some dialogs don't have 'close' buttons already (possible fix below):

Mage.Client/src/main/java/mage/client/dialog/CardInfoWindowDialog.java
```
case EXILE:
this.setFrameIcon(new ImageIcon(ImageManagerImpl.instance.getExileImage()));
+ this.setClosable(true);
break;
case COMPANION:
this.setFrameIcon(new ImageIcon(ImageManagerImpl.instance.getTokenIconImage()));
+ this.setClosable(true);
break;
case OTHER:
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with Mage.Client/src/main/java/mage/client/dialog/CardInfoWindowDialog.java and inspect how EXILE and COMPANION dialogs are configured. Trace how the client creates and tracks the exile, revealed, graveyard, and other dialogs to determine where a single close-all action belongs. Done means the listed dialog types can be closed individually and all open dialog boxes can be dismissed together.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.