magefree / magefree/mage

Refactor: many sets contains wrong block and parent set info

Open
#10,184 5 comments 0 reactions 0 assignees View on GitHub
refactoring
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

Some sets contains wrong info about block (~134) and parent set info (~358). It's not a critical, but must be fixed someday. Block info used to group sets in the GUI choose dialog. Parent set info used to generate a booster.

Search that code to enable verify test:
* TODO: comments it and run to find a problems`

Logs sample for wrong block:
```
Error: set with wrong blockName settings: 10E - Tenth Edition (blockName = null, but must be Core Set)
Error: set with wrong blockName settings: 2ED - Unlimited Edition (blockName = null, but must be Core Set)
Error: set with wrong blockName settings: 2X2 - Double Masters 2022 (blockName = Reprint, but must be null)
Error: set with wrong blockName settings: 2XM - Double Masters (blockName = Reprint, but must be null)
Error: set with wrong blockName settings: 3ED - Revised Edition (blockName = null, but must be Core Set)
```

Logs sample for wrong parent set:
```
Error: set with wrong parentSet settings: WTH - Weatherlight (parentSet = MIR, but must be null)
Error: set with wrong parentSet settings: WWK - Worldwake (parentSet = ZEN, but must be null)
Error: set with wrong parentSet settings: XANA - Arena New Player Experience Extras (parentSet = null, but must be ANA - ArenaNewPlayerExperience.getInstance())
Error: set with wrong parentSet settings: ZNC - Zendikar Rising Commander (parentSet = null, but must be ZNR - ZendikarRising.getInstance())
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the set metadata validation code and the TODO comments referenced in the issue, then enable and run the verification test to reproduce the reported mismatches. Correct the blockName and parentSet values for the affected sets, and confirm the verification output contains no wrong settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.