Refactor: many sets are outdated and must be renamed
- Dominant language
- Java
- Stars
- 2.4k
- Forks
- 940
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 160
Description
Some sets (~32) were renamed so xmage must rename it to. It need change in many places like:
- set's name;
- set's class name;
- comments in the code like `ScryfallImageSupportCards`;
- script files like `known-sets.txt` and `mtg-cards-data.txt`;
- maybe another places too, use search to find all places

Important: some sets like Warhammer 40,000 must be renamed after [all set's PRs](https://github.com/magefree/mage/pulls?q=is%3Apr+is%3Aopen+40k) merged;
Search that code to enable verify test:
* `TODO: enable after merge of 40k's cards pull requests (needs before set rename)`
All problem sets:
```
Error: wrong set name or set code: 40K - Warhammer 40,000 (mtgjson set for same code: Warhammer 40,000 Commander)
Error: wrong set name or set code: C13 - Commander 2013 Edition (mtgjson set for same code: Commander 2013)
Error: wrong set name or set code: C14 - Commander 2014 Edition (mtgjson set for same code: Commander 2014)
Error: wrong set name or set code: C15 - Commander 2015 Edition (mtgjson set for same code: Commander 2015)
Error: wrong set name or set code: C16 - Commander 2016 Edition (mtgjson set for same code: Commander 2016)
Error: wrong set name or set code: C17 - Commander 2017 Edition (mtgjson set for same code: Commander 2017)
Error: wrong set name or set code: C18 - Commander 2018 Edition (mtgjson set for same code: Commander 2018)
Error: wrong set name or set code: C19 - Commander 2019 Edition (mtgjson set for same code: Commander 2019)
Error: wrong set name or set code: C20 - Commander 2020 Edition (mtgjson set for same code: Commander 2020)
Error: wrong set name or set code: C21 - Commander 2021 Edition (mtgjson set for same code: Commander 2021)
Error: wrong set name or set code: CMB1 - Mystery Booster Playtest (mtgjson set for same code: Mystery Booster Playtest Cards 2019)
Error: wrong set name or set code: CMD - Commander (mtgjson set for same code: Commander 2011)
Error: wrong set name or set code: DVD - Duel Decks: Anthology, Divine vs. Demonic (mtgjson set for same code: Duel Decks Anthology: Divine vs. Demonic)
Error: wrong set name or set code: EVG - Duel Decks: Anthology, Elves vs. Goblins (mtgjson set for same code: Duel Decks Anthology: Elves vs. Goblins)
Error: wrong set name or set code: G17 - Gift Pack 2017 (mtgjson set for same code: 2017 Gift Pack)
Error: wrong set name or set code: GK1 - Guilds of Ravnica Guild Kits (mtgjson set for same code: GRN Guild Kit)
Error: wrong set name or set code: GK2 - Ravnica Allegiance Guild Kits (mtgjson set for same code: RNA Guild Kit)
Error: wrong set name or set code: GS1 - Global Series: Jiang Yanggu & Mu Yanling (mtgjson set for same code: Global Series Jiang Yanggu & Mu Yanling)
Error: wrong set name or set code: GVL - Duel Decks: Anthology, Garruk vs. Liliana (mtgjson set for same code: Duel Decks Anthology: Garruk vs. Liliana)
Error: wrong set name or set code: H17 - HASCON Promo 2017 (mtgjson set for same code: HasCon 2017)
Error: wrong set name or set code: JVC - Duel Decks: Anthology, Jace vs. Chandra (mtgjson set for same code: Duel Decks Anthology: Jace vs. Chandra)
Error: wrong set name or set code: P15A - Fifteenth Anniversary Cards (mtgjson set for same code: 15th Anniversary Cards)
Error: wrong set name or set code: PC2 - Planechase 2012 Edition (mtgjson set for same code: Planechase 2012)
Error: wrong set name or set code: PIDW - IDW Comics 2012 (mtgjson set for same code: IDW Comics Inserts)
Error: wrong set name or set code: PMEI - Magazine Inserts (mtgjson set for same code: Media Inserts)
Error: wrong set name or set code: PRW2 - Ravnica Allegiance Ravnica Weekend (mtgjson set for same code: RNA Ravnica Weekend)
Error: wrong set name or set code: PSS2 - Ixalan Standard Showdown (mtgjson set for same code: XLN Standard Showdown)
Error: wrong set name or set code: PUMA - Ultimate Box Topper Promos (mtgjson set for same code: Ultimate Box Topper)
Error: wrong set name or set code: PWOR - Worlds (mtgjson set for same code: World Championship Promos)
Error: wrong set name or set code: PXTC - Ixalan Treasure Chest (mtgjson set for same code: XLN Treasure Chest)
Error: wrong set name or set code: SUM - Summer Magic (mtgjson set for same code: Summer Magic / Edgar)
Error: wrong set name or set code: TSB - Time Spiral "Timeshifted" (mtgjson set for same code: Time Spiral Timeshifted)
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Search the codebase for each listed set name and code, including set classes, comments, known-sets.txt, and mtg-cards-data.txt. Start with the verification test containing `TODO: enable after merge of 40k's cards pull requests (needs before set rename)` and review the linked 40K pull requests before changing that set. Done means all listed names are consistent and the verification test passes after the prerequisite merges.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100