magefree / magefree/mage

Tests: some mana tests must be rewritten to use checkAbility

Open
#10,144 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Java
Stars
2.4k
Forks
940
Avg merge
2d 12h
Merged PRs (30d)
160

Description

There are few tests that calls mana ability multiple times on wrong places (player can't activate mana ability and it must fail instead continue).

Two possible use cases:
- wrong test logic or miss commands - so test must be checked and fixed;
- correct test logic -- it uses mana pool to check real mana activates -- so it must be rewritten to use checkAbility;

Search [code](https://github.com/magefree/mage/commit/8f742081b6fd3064009c077f8a0a3d1e90b7a422) for `enable assert and rewrite failed activateManaAbility tests` to enable check and see failed tests:
![shot_230323_232908](https://user-images.githubusercontent.com/8344157/227328142-2c53273f-6de5-4076-b330-5ec5e2d9931d.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.