on(end) should only be triggered after a read has been attempted
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 239
- Forks
- 27
- Avg merge
- 27m
- Merged PRs (30d)
- 1
Description
small issue, but atm push(null) starts the statemachine - it shouldn't, but a even better fix is waiting on triggering the end at all until a read (ondata, resume, read, pipe) has been called
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the stream state machine around push(null) and the end event, then reproduce the case where push(null) occurs before ondata, resume, read, or pipe is called. Done means end is not triggered until one of those read attempts occurs, with regression coverage for the current premature behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100