mafintosh / mafintosh/pump

Browser Support

Open
#6 12 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
917
Forks
64
PR merge metrics
No merged PRs in 30d

Description

I see #5, but it is not mentioned in the readme and imports fs.

I can open a PR to run the tests in Sauce Labs like @feross mentioned, and add a badge to the readme if you want. I am not sure how to do it without a tool like mocha, but I am sure I could figure it out.

If you are bundling the package with a tool like browserify you would have to exclude the fs module. There is a fairly simple way I have used to support smaller browser builds using a small DI wrapper. I can make a PR for this to if you are interested.

Thanks!!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the README and existing test setup, then review issue #5 and the browserify/fs constraint described here. Clarify whether the scope is Sauce Labs test runs and a README badge, browser bundling support, or both; done means the agreed browser-support path is tested and documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
documentation, testing, web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.