mafintosh / mafintosh/pump

Error are not triggered

Open
#54 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
917
Forks
64
PR merge metrics
No merged PRs in 30d

Description

Please see 'end-of-stream' module's second param options,
```javascript
eos(stream, {readable: reading, writable: writing}, function (err) {
if (err) return callback(err)
closed = true
callback()
})
```
can you change the codes to
```javascript
eos(stream, {readable: reading, writable: writing, error: true}, function (err) {
if (err) return callback(err)
closed = true
callback()
})
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the pump code containing the `eos(stream, ...)` call and compare its options with the end-of-stream module's behavior. Done means errors from the stream trigger the callback through the requested error-handling option.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.