mafintosh / mafintosh/pump

Pass error in stream.destroy()

Open
#35 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
917
Forks
64
PR merge metrics
No merged PRs in 30d

Description

Why stream.destroy is not call with err argument ?

In my stream object it will be nice to get the error.

```
class AskReply extends Transform {
destroy(error) { //error is always undefined
return super.destroy(error);
}
}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the stream.destroy() handling in pump and the Transform subclass example, then trace how the error reaches super.destroy(error). Done means the originating stream error is available as the destroy() argument for the other stream, with behavior covered by an appropriate regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.