mafintosh / mafintosh/pejs

Locals aren't inherited when using file blocks with new locals

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
37
Forks
6
PR merge metrics
No merged PRs in 30d

Description

When doing the following in a base file.

<%{ './template.html' { newLocal: 1 } }%>

The only accessible local variable in template.html is newLocal, even though there are more locals defined in the base file.

Expected to have all locals from base with newLocal in template.html.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the file-block example from the issue and trace how locals are passed into template.html. Done means template.html can access the base file's existing locals together with the supplied newLocal value.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.