mafintosh / mafintosh/peerflix
--remove not triggered when peerflix exits because player was closed
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 6.3k
- Forks
- 668
- PR merge metrics
- No merged PRs in 30d
Description
`-r, --remove remove files on exit`
When --remove is set, files should be removed regardless of how we exit.
Currently, `engine.remove()` is only triggered on `SIGINT` and `SIGTERM` and not when we exit after the player closes as we are directly calling `process.exit(0)` from the `[player].on('exit')` callbacks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the [player].on('exit') callbacks and compare their process.exit(0) path with the SIGINT and SIGTERM cleanup paths that call engine.remove(). Verify that closing the player while --remove is set removes the files before the process exits.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100