mafintosh / mafintosh/mp4-stream

Fix example

Open
#10 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
215
Forks
22
PR merge metrics
No merged PRs in 30d

Description

The `next` reference is missing in the sample:

```
var encoder = mp4.encode()
var decoder = mp4.decode()

decoder.on('box', function (headers, next) {
decoder.decode(function (box) {
encoder.box(box, next)
})
})

fs.createReadStream('my-movie.mp4').pipe(decoder)
encoder.pipe(fs.createWriteStream('my-movie-copy.mp4'))
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the documentation or example containing the `mp4.encode()` and `mp4.decode()` snippet from the issue. Check how the decoder callback receives `next`, update the sample so it is included, and verify that the documented stream-copy example is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.