mafintosh / mafintosh/hms

File size when deploying varies depending on .gitignore configuration

Open
#32 0 comments 0 reactions 1 assignee View on GitHub

@mafintosh is already working on this.

Since Jan 27, 2015.

Dominant language
JavaScript
Stars
37
Forks
8
PR merge metrics
No merged PRs in 30d

Description

There seems to be a problem in properly ignoring files based on the .gitignore file on deploy: If there is an trailing slash in a folder name it will not get ignored.

It goes as the following, with slash:

node_modules/

Results in a total of 1.6 mb uploaded to the server.

Removing the trailing slash:

node_modules

Reduces the size to 2.3 kB

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.