mafintosh / mafintosh/flat-tree
fullRoots and passing in results array
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 147
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
@mafintosh I noticed that `fullRoots` takes an optional array as second argument, but I can't find any usage of this in any dependent module. This was added two years ago. It's also not documented.
Mind if I clean that up?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the fullRoots implementation and inspect how its optional second argument and the results array are handled. Search dependent-module usage to establish whether the argument can be removed or needs documentation; done means the API is consistently updated and its behavior is covered or clearly documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100