madpah / madpah/serializable

style: get rid of unnecessary type conversions

Open
#23 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
Python
Stars
7
Forks
6
PR merge metrics
No merged PRs in 30d

Description

examples:

# is string already!  why the cast? 
            if type(type_) == str:
                type_to_parse = str(type_)
# is in list already! why the cast? 
                    if results.get('array_type', None) in self._SORTED_CONTAINERS_TYPES:
                        mapped_array_type = self._SORTED_CONTAINERS_TYPES.get(str(results.get("array_type")))

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the repository for the two Python snippets shown in the issue, including the type_ conversion and the array_type mapping. Review whether each conversion is redundant, remove only the unnecessary conversions, and verify that the serialization and deserialization behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.