madhums / madhums/node-imager

Support for additional S3 headers

Open
#86 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
267
Forks
60
PR merge metrics
No merged PRs in 30d

Description

When putting files to S3 it sometimes makes sense to set some Cache-Control header for the file (especially if you're using cloudfront to distribute it later).
S3 supports it through `x-amz-meta-Cache-Control` header on PUT request (and there are a lot of other properties which can be set using these "meta" headers).
I'd like to know if imager is interested in supporting this type of functionality.

E.g. pushToS3 can be modified to take the `options` dictionary from `s3Config`. If this all sounds ok, I can create a pull request.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the pushToS3 entry point and how s3Config is consumed. Check the existing S3 upload behavior, then determine how the options dictionary should provide Cache-Control and other metadata headers; done means those headers are sent on PUT requests without breaking existing uploads.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, javascript, node.js
Domain
backend, cloud
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.