madhums / madhums/node-imager

Make resizing actually resize to the given dimensions

Open
#30 1 comment 0 reactions 1 assignee View on GitHub

@madhums is already working on this.

Since Sep 17, 2014.

bug
Dominant language
JavaScript
Stars
267
Forks
60
PR merge metrics
No merged PRs in 30d

Description

By default, using gm to resize will resize to what it deems the best constraint proportionally sized image (unless you pass in `"!"` as the third argument for `resize()`). It should still resize the images, but with the size that was passed in. Not sure if this is a node-gm thing in itself, but I spent some time trying to figure it out and it seems the only way to fix it is to force a crop, or use the third param (which won't resize it proportionally).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.