macvim-dev / macvim-dev/macvim
Remove Carbon dependencies
Nobody has claimed this yet.
- Dominant language
- Vim Script
- Stars
- 7.9k
- Forks
- 691
- PR merge metrics
- No merged PRs in 30d
Description
Currently, MacVim still links against the Carbon framework, which apparently still works under Big Sur. However, the API has been deprecated for a decade, and we should just remove it and port the function to newer Cocoa calls. If I remove Carbon from linkage, these are the linked symbols I see:
- _SetSystemUIMode (Fixed in #1155)
- _TISCopyCurrentASCIICapableKeyboardInputSource
- _TISCopyCurrentKeyboardInputSource
- _TISCopyInputSourceForLanguage
- _TISGetInputSourceProperty
- _TISSelectInputSource
- _kTISNotifySelectedKeyboardInputSourceChanged
- _kTISPropertyInputSourceID
Go through them and port them.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the MacVim source and build configuration for each remaining listed TIS symbol, after confirming the Carbon linkage and the SetSystemUIMode change in #1155. Read the surrounding input-source handling and verify the macOS build no longer links Carbon or references any of the listed symbols.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- macos
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100