macvim-dev / macvim-dev/macvim

Issues after last commit to src/MacVim/MMBackend.m

Open
#1,050 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Vim Script
Stars
7.9k
Forks
691
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
I have several issues with the current master:

VIM - Vi IMproved 8.2 (2019 Dec 12, compiled May 30 2020 15:13:09)
macOS version
Included patches: 1-830

At startup, at least some of the highlight commands from gvimrc are not executed. For example, I have:

set cursorline
set cursorlineopt=screenline
hi CursorLine	NONE
hi CursorLine	gui=underline	guisp=gray

but do not get a underline. Furthermore I sometimes see artifacts of my status bar while scrolling.

Screenshot 2020-05-30 at 14 37 58

I suspect the latest changes in src/MacVim/MMBackend.m as the reason for this behaviour. If I revert this part of the commit:

         while (CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0, true)
                   == kCFRunLoopRunHandledSource)
              ;   // do nothing
+       [self processInputQueue];
  }
  - (void)flushQueue:(BOOL)force

I can no longer reproduce the issues and MacVIM behaves as before.

Can someone please check whether the [self processInputQueue]; is necessary at this point or whether it can cause such problems?

Environment (please complete the following information):

  • VIM - Vi IMproved 8.2 (2019 Dec 12, compiled May 30 2020 15:13:09), Included patches: 1-830
  • OS: macOS 10.15.5
  • GUI: MacVIM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/MacVim/MMBackend.m and inspect the change that adds [self processInputQueue] after CFRunLoopRunInMode. Reproduce the startup highlighting and scrolling artifacts with the reported gvimrc settings on macOS, then compare behavior with that line reverted. Done means the regression is isolated and the appropriate behavior is covered by the project’s available verification process.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos, objective-c, vim
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.