macadmins / macadmins/sofa

Model Overrides data issue

Open Beginner friendly
#321 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Vue
Stars
449
Forks
38
Avg merge
4h 43m
Merged PRs (30d)
7

Description

Good day,
Love the project, so much so that I was looking into importing model types into one of our systems but found some inaccuracies that I think are limited to the ModelOverrides.json stuff.

I only had limited data in our older system to compare it with and at least found the following board IDs don't match to the correct model identifier. This is the data I was comparing SOFA with:

| board | identifier |
|--------|--------|
| Mac-F60DEB81FF30ACF6 | MacPro6,1 |
| Mac-7BA5B2DFE22DDD8C | Macmini8,1 |
| Mac-35C5E08120C7EEAF | Macmini7,1 |
| Mac-5F9802EFE386AA28 | MacBookPro16,2 |
| Mac-E1008331FDC96864 | MacBookPro16,1 |
| Mac-53FDB3D8DB8CA971 | MacBookPro15,4 |
| Mac-1E7E29AD0135F9BC | MacBookPro15,3 |
| Mac-827FB448E656EC26 | MacBookPro15,2 |
| Mac-937A206F2EE63C01 | MacBookPro15,1 |
| Mac-CAD6701F7CEA0921 | MacBookPro14,2 |
| Mac-B4831CEBD52A0C4C | MacBookPro14,1 |
| Mac-A5C67F76ED83108C | MacBookPro13,3 |
| Mac-66E35819EE2D0D05 | MacBookPro13,2 |
| Mac-473D31EABEB93F9B | MacBookPro13,1 |
| Mac-E43C1C25D4880AD6 | MacBookPro12,1 |
| Mac-06F11F11946D27C5 | MacBookPro11,5 |
| Mac-06F11FD93F0323C5 | MacBookPro11,4 |
| Mac-0CFF9C7C2B63DF8D | MacBookAir9,1 |
| Mac-226CB3C6A851A671 | MacBookAir8,2 |
| Mac-937CB26E2E02BB01 | MacBookAir7,2 |
| Mac-9AE82516C7C6B903 | MacBook9,1 |
| Mac-B809C3757DA9BB8D | iMac17,1 |
| Mac-42FD25EABCABB274 | iMac15,1 |

Some of those board IDs are included in the list but with different model identifiers so, hopefully, it's just a misalignment and reasonably trivial to fix.

Thanks,
Chris

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open ModelOverrides.json and compare the listed board IDs with the model identifiers in the issue. Correct the mismatched mappings, then verify that every listed board ID resolves to the identifier shown in the report.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos
Domain
operating-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.