macadmins / macadmins/nudge

Feature Request: Support an array of strings for targetedOSVersionRule

Open
#447 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

low-priority
Dominant language
Swift
Stars
1.3k
Forks
207
PR merge metrics
No merged PRs in 30d

Description

Low priority request to support an array of strings, instead of just a single string, for the `targetedOSVersionRule` key. This would mimic the old behavior of the deprecated `targetedOSVersions` key.

The main scenario I had for requesting this is to support the workarounds for #417. The most specific way to accomplish this is a `targetedOSVersionRule` that specifies: 11, 12.0, 12.0.1, 12.1, 12.2 and 12.2.1. Currently that would require six dictionaries to accomplish.

That said, once #417 gets resolved it'll likely negate my particular need for this request, so in my opinion that is where efforts should be made.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the configuration handling for the `targetedOSVersionRule` key and compare it with the deprecated `targetedOSVersions` behavior. Verify how multiple versions should be matched, including 11, 12.0, 12.0.1, 12.1, 12.2, and 12.2.1, and confirm that the workaround for #417 is covered before considering the work complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos, swift
Domain
desktop, operating-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.