macadmins / macadmins/installapplications
If a user script fails, InstallApplications should stop running
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 307
- Forks
- 59
- PR merge metrics
- No merged PRs in 30d
Description
if root scripts fail multiple times, the run will stop, however if a user script fails, the run will keep going.
This is could be problematic for environments that need the user section to complete successfully. With https://github.com/macadmins/installapplications/commit/5218c9683c0ec72e784106611a93eafb5b0ed20f I fixed the infinite looping when not exiting 0, but introduced this issue.
This will be a difficult one to solve since the user side runs in a different process and we cannot capture the state of the run itself.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review commit 5218c9683c0ec72e784106611a93eafb5b0ed20f and trace how user scripts run in their separate process. The work is complete when a failing user script causes InstallApplications to stop, without restoring the infinite-loop behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100