mabdi / mabdi/small-amp

Custom error handlers interrupts the amplification

Open
#97 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted invalid
Dominant language
Smalltalk
Stars
6
Forks
4
PR merge metrics
No merged PRs in 30d

Description

The trait `TTaskExecutor` (traits or classes like it) opens custom exceptionHandler.

```smalltalk
executeTask: aTaskExecution
[ self noteBusy. aTaskExecution value. self noteFree ]
on: Error
do: [ :error | self exceptionHandler handleException: error ]
```
The tests using these classes may interrupted and never be finished.
(`TKTLocalProcessTaskRunner` uses `TTaskExecutor`)
```smalltalk
testCacheSizeFor_amp_A78
| cache requestedSize tmp_yxDSiRuEgR1 tmp_Wh1LQxSblB2 tmp_P3cDMPRpKV3 tmp_CQXiNqyAMj4 tmp_Gka6xX3Oxw5 tmp_MfFvl0EPML6 tmp_W3fLy0ggoO7 tmp_pxmJXKfM6v8 |
cache := BlLocalImageCache new.
tmp_yxDSiRuEgR1 := cache taskitRunner: TKTLocalProcessTaskRunner new.
tmp_P3cDMPRpKV3 := cache defaultImageSizes.
tmp_Wh1LQxSblB2 := tmp_P3cDMPRpKV3 second.
requestedSize := tmp_Wh1LQxSblB2 - 1.
tmp_CQXiNqyAMj4 := cache defaultImageSizes.
requestedSize := tmp_CQXiNqyAMj4 second.
tmp_MfFvl0EPML6 := cache defaultImageSizes.
cache initHousekeeping.
tmp_Gka6xX3Oxw5 := tmp_MfFvl0EPML6 third.
requestedSize := tmp_Gka6xX3Oxw5 + 1.
tmp_pxmJXKfM6v8 := cache defaultImageSizes.
tmp_W3fLy0ggoO7 := tmp_pxmJXKfM6v8 last.
requestedSize := tmp_W3fLy0ggoO7 + 1
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the TTaskExecutor executeTask: method and the TKTLocalProcessTaskRunner use mentioned in the issue. Reproduce the interruption with the shown testCacheSizeFor_amp_A78 example and trace how the custom exceptionHandler affects test execution. Done means amplified tests using these task runners are not interrupted prematurely and can finish.

Written by the indexing model from the issue text.

Assessment

Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.