mRemoteNG / mRemoteNG/mRemoteNG

ver: 1.78.2: The application crashes with an error when closing a tab with open connections.

Open
#2,706 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

1.78.* Bug Connections Need 2 check UI/UX Windows
Dominant language
C#
Stars
11.1k
Forks
1.6k
Avg merge
16h 58m
Merged PRs (30d)
55

Description

OS: Microsoft Windows NT 10.0.26100.0
mRemoteNG Connection Manager Version: 1.78.2 (Nightly Build 2932) (and earlier: 1.77.1, 1.77.3)
Edition: MSI
Cannot access a disposed object.
Object name: 'ConnectionWindow'.
   at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)
   at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)
--- End of stack trace from previous location ---
   at System.Windows.Forms.Control.MarshaledInvoke(Control caller, Delegate method, Object[] args, Boolean synchronous)
   at System.Windows.Forms.Control.Invoke(Delegate method, Object[] args)
   at System.Windows.Forms.Control.Invoke(Action method)
   at mRemoteNG.UI.Window.ConnectionWindow.Prot_Event_Closed(Object sender) in D:\Work\mRemoteNG\1.78.2-dev\mRemoteNG\UI\Window\ConnectionWindow.cs:line 780
   at mRemoteNG.Connection.Protocol.ProtocolBase.CloseBG() in D:\Work\mRemoteNG\1.78.2-dev\mRemoteNG\Connection\Protocol\ProtocolBase.cs:line 156
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Windows.Forms.Control.Invoke(Action method)
   at mRemoteNG.UI.Window.ConnectionWindow.Prot_Event_Closed(Object sender) in D:\Work\mRemoteNG\1.78.2-dev\mRemoteNG\UI\Window\ConnectionWindow.cs:line 780
   at mRemoteNG.Connection.Protocol.ProtocolBase.CloseBG() in D:\Work\mRemoteNG\1.78.2-dev\mRemoteNG\Connection\Protocol\ProtocolBase.cs:line 156
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

P.S.:
I look at the error trace and see a path that does not exist in my system: D:\Work\mRemoteNG\1.78.2-dev\mRemoteNG\...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with mRemoteNG/UI/Window/ConnectionWindow.cs at Prot_Event_Closed, especially line 780, and trace the close path into mRemoteNG/Connection/Protocol/ProtocolBase.cs at CloseBG, line 156. Reproduce closing a tab with open connections and follow the disposal and invoke behavior. Done means the application no longer crashes in this scenario.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.