mProjectsCode / mProjectsCode/obsidian-shiki-plugin

Problems when typing in Korean language

Open
#89 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
238
Forks
25
PR merge metrics
No merged PRs in 30d

Description

  • The Plugin is up to date
  • Obsidian is up to date

Describe the bug

Sometimes the Korean character won't render during typing.

To Reproduce

https://github.com/user-attachments/assets/62d19994-17d0-43b0-934e-bfd5a652013d

When you type Korean in a note with code blocks that is highlighted with the plugin, some of the characters won't render until spacebar or arrow key is hit to move the cursor.

You can see the letter "나" is not appearing as soon as type the second "ㅏ".

I am going refer Korean alphabets(Hangeul) as letters/characters (e.g. ㄱ, ㅏ, ㅇ) and completed ones as words (e.g. 강, 하)

ㄱ (ㄱ)
가 (ㄱ + ㅏ)
간 (ㄱ + ㅏ + ㄴ)
가나 (ㄱ + ㅏ + ㄴ + ㅏ)

Here is a order of keys I have typed.

While typing consecutively, when I hit the 4th key , the text should be rendered as 가나. However, the disappears until I move the cursor with arrow key or hit spacebar. Clicking elsewhere somehow erases .

Expected behavior

https://github.com/user-attachments/assets/0fcaeb9e-c472-4584-8380-a010b4283111

Screenshots
If applicable, add screenshots to help explain your problem.

Occurs on

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

Plugin version

0.7.7

Additional context

I have updated Obsidian from 1.12.x to 1.13.4, but the problem was still there in 1.12.

I could try to help since I am the one who's using Korean here. I am not familiar with working on Obsidian plugin but I am happy to learn how can I contribute. Thanks.

Image

List of plugins I am using. I turned on restricted mode and the issue wasn't reproducible.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on Windows with Korean input, a highlighted code block, and the plugin enabled, then compare it with restricted mode. Trace the code-block rendering and editor update entry points involved in composing Hangeul. Done means newly composed characters render immediately and remain correct after typing, cursor movement, spacebar, or clicking elsewhere.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop-dev, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.