mProjectsCode / mProjectsCode/obsidian-shiki-plugin
Highlighting stops when rumdl (plugin) does format on save on CTRL+S.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 238
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
- The Plugin is up to date
- Obsidian is up to date
Describe the bug
[!NOTE]
I don't know if this is a bug inobsidian-shiki-pluginor Obsidian. It's likely not inobsidian-rumdl?Just wanted to create an issue with info about it, and hopefully someone can figure out where and why it happens.
I use rumdl for linting and format on save:
- https://github.com/rvben/obsidian-rumdl
- Installed using BRAT: https://github.com/TfTHacker/obsidian42-brat
When I do changes in a note where CTRL+S triggers rumdl format/fix, and rumdl does changes, this highlighter stops highlighting code.
To Reproduce
- Install this plugin and rumdl.
- Enable format on save with the rumdl plugin.
- Create a note with a code block, and add two-three consecutive lines somewhere outside the code block.
- Save file
CTRL+S, which triggers rumdl, which will remove consecutive blank lines. - See Shiki highligter stopped highlighting code.
Expected behavior
Highlighting of code should not stop.
Screenshots
https://github.com/user-attachments/assets/363f53e0-02e0-4f24-8c75-22af1d840700
Occurs on
- Windows
- macOS
- Linux
- Android
- iOS
Plugin version
v0.7.7
Additional context
Add any other context about the problem here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. First reproduce the issue with Obsidian, obsidian-shiki-plugin v0.7.7, and rumdl format-on-save, then inspect the plugin's highlighting update path around an externally modified note. Done means code highlighting remains active after CTRL+S causes rumdl to remove consecutive blank lines.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- desktop-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100