mProjectsCode / mProjectsCode/obsidian-media-db-plugin

Movie OMDB - Pagination - missing results

Open
#144 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
491
Forks
52
Avg merge
2h 17m
Merged PRs (30d)
1

Description

  • The Plugin is up to date
  • Obsidian is up to date

Describe the bug
it seems that pagination is not taking into account for the OMDB API. Example, when you search on "Seven", you only get a few results in the api but if you add the pagination, you get the next results.
Example: https://www.omdbapi.com/?s=Seven&apikey=[your_Api_Key]&page=4

To Reproduce
Search for Seven: you will only see a few results
Go on the url with your API Key and add &page=2 ... you will see the other results (for sure, depending on the search, there might be a lot of pages).

Expected behavior
Either a scroll or a pagination could be helpful because right now, some movies are missing.

Screenshots

Occurs on
Tested on Windows. No idea for the others but I guess the behaviour is the same.

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

Plugin version
0.6.0

Additional context
Thank you for your help!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the OMDB search request for “Seven” and compare the current request with the documented URL including page=2 or page=4. Done means the plugin exposes the additional OMDB results through pagination or scrolling, rather than showing only the first response.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.