Design for StrCtx that takes delimiter or maximum size
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 192
- Forks
- 43
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 1
Description
See initial discussion in https://github.com/m4b/scroll/issues/108#issuecomment-3217055258
We may want to change behavior of DelimiterUntil, but probably more likely we'd add a ctx with this behavior.
Here are the only uses of DelimiterUntil in goblin:
```
src/pe/symbol.rs
207: .pread_with(offset, ctx::StrCtx::DelimiterUntil(0, 8))
466: .pread_with(offset, ctx::StrCtx::DelimiterUntil(0, length))
```
Either way it's a breaking change since we don't have non-exhaustive on StrCtx.
cc @kkent030315
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the discussion linked from issue 108, then inspect the two DelimiterUntil uses in src/pe/symbol.rs at lines 207 and 466. Compare whether the behavior belongs in DelimiterUntil or a new StrCtx variant, and document the breaking API impact; done means the design decision and affected callers are settled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- reverse-engineering
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100