m4b / m4b/goblin

EASY PE: should Import.name be option?

Open
#38 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue help wanted
Dominant language
Rust
Stars
1.5k
Forks
202
PR merge metrics
No merged PRs in 30d

Description

```
Import {
name: "ORDINAL 0",
dll: "WS2_32.dll",
ordinal: 0,
offset: 62264,
rva: 0,
size: 4
},
```

this ("ORDINAL 0") is ~~basically~~ a stupid hack, but it makes working with Import much nicer. Alternatively, could make an enum, but, i dunno that just annoys me for some reason

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the PE Import definition and its consumers. Compare the proposed Option representation with the enum alternative, including how ordinal-only imports are exposed. Done means the representation is chosen and the "ORDINAL 0" workaround is no longer needed without breaking existing Import users.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
reverse-engineering
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.